Skip to content

fix: default storageClass for gitea valkey and oauth2proxy redis#3423

Open
j-zimnowoda wants to merge 11 commits into
mainfrom
gh-3386
Open

fix: default storageClass for gitea valkey and oauth2proxy redis#3423
j-zimnowoda wants to merge 11 commits into
mainfrom
gh-3386

Conversation

@j-zimnowoda

@j-zimnowoda j-zimnowoda commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

#3386

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@j-zimnowoda j-zimnowoda requested review from Ani1357 and merll as code owners July 6, 2026 16:21
defaultStorageClass: {{ if eq $v.cluster.provider "linode" }}linode-block-storage{{ else }}{{ $v.cluster.defaultStorageClass | default "" }}{{ end }}
security:
allowInsecureImages: true
{{- with $v.cluster | get "defaultStorageClass" nil }}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade path still needs to be implemented

@svcAPLBot

svcAPLBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Comparison of Helm chart templating output:

# git-server/templates/pvc.yaml

@@ spec @@
! + one map entry added:
+ storageClassName: linode-block-storage

# gitea/templates/gitea/pvc.yaml

@@ spec @@
! + one map entry added:
+ storageClassName: linode-block-storage

# raw/templates/resources.yaml

@@ spec @@
# v1/PersistentVolumeClaim/gitea-backup
! + one map entry added:
+ storageClassName: linode-block-storage

# harbor/templates/redis/statefulset.yaml

@@ spec.volumeClaimTemplates.v1/PersistentVolumeClaim/data.spec @@
! + one map entry added:
+ storageClassName: linode-block-storage

# harbor/templates/trivy/trivy-sts.yaml

@@ spec.volumeClaimTemplates.v1/PersistentVolumeClaim/data.spec @@
! + one map entry added:
+ storageClassName: linode-block-storage

# kubeflow-pipelines/templates/mysql/pvc.yaml

@@ spec @@
! + one map entry added:
+ storageClassName: linode-block-storage

# kube-prometheus-stack/templates/prometheus/prometheus.yaml

@@ spec.storage.volumeClaimTemplate.spec @@
! + one map entry added:
+ storageClassName: linode-block-storage

# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml

# values-repo.yaml

@@ cluster @@
! - one map entry removed:
- defaultStorageClass:

@j-zimnowoda j-zimnowoda marked this pull request as draft July 6, 2026 16:43
@j-zimnowoda j-zimnowoda marked this pull request as ready for review July 7, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants